Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Replace toLower with toLowerANSI where applicable #9790

Merged
merged 12 commits into from
Mar 7, 2024

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Title.

Changes were all done manually, regular toLower was kept where operated text was user-facing.
I'm not sure if any issues will result from the changes made in the AVD files. I don't think so, but it should be tested.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/optimization Release Notes: **IMPROVED:** label Feb 10, 2024
Co-authored-by: PabstMirror <[email protected]>
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If stuff I suggested is rejected, I'll make another PR containing the rejects.

addons/common/functions/fnc_showHud.sqf Outdated Show resolved Hide resolved
addons/repair/functions/fnc_setHitPointDamage.sqf Outdated Show resolved Hide resolved
addons/tagging/XEH_preStart.sqf Outdated Show resolved Hide resolved
addons/tagging/XEH_preStart.sqf Outdated Show resolved Hide resolved
addons/vehicle_damage/functions/fnc_handleCookoff.sqf Outdated Show resolved Hide resolved
addons/viewports/functions/fnc_eachFrame.sqf Outdated Show resolved Hide resolved
@johnb432
Copy link
Contributor

johnb432 commented Mar 4, 2024

I'm not sure if any issues will result from the changes made in the AVD files.

Doubtful.

Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnb432 johnb432 merged commit e06c6f7 into master Mar 7, 2024
5 checks passed
@johnb432 johnb432 deleted the cause-merge-conflicts-toLowerANSI branch March 7, 2024 21:08
@PabstMirror PabstMirror added this to the 3.17.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants