Ability to use AT Launchers in the prone position #7002

PiZZAD0X · 2019-05-16T16:48:27Z

When merged this pull request will:

Enable state/stance transitions to the prone AT Launcher position
Uses a key EH to block engine state transition (which triggers the ArmA 3 statemachine behaviour that forces players out of the prone AT launcher state) and plays transition animations. This is the only solution I have found to get around the engine limitation of that state check. Any help on optimizing/making that workaround reliable is greatly appreciated.
Includes configs that fix the prone AT animation for aiming/headpos (ACE 2 Launcher Prone config port)
This PR needs animation work (the transitions between prone AT and standing AT, prone AT reload for muzzle loaded AT, and prone AT reload for breech loaded AT.

https://www.youtube.com/watch?v=7z6qmQPTAnA

addons/pronelauncher/XEH_preInit.sqf

addons/pronelauncher/config.cpp

-removed unnecessary requiredAddons

PabstMirror · 2019-05-17T04:13:20Z

Need to block keybind stuff when in ffv (e.g. offroad)

Dystopian · 2019-05-17T05:13:49Z

addons/pronelauncher/CfgMovesBasic.hpp

+ class Actions {
+ class CivilStandActions; // External class reference
+ class CivilProneActions : CivilStandActions {
+ SecondaryWeapon = "ACE_LauncherProne";


maybe all these ACE_ names should be replaced with GVAR/QGVAR values

ACE3/addons/movement/CfgMoves.hpp

Line 102 in e5a15d2

class ACE_Climb: AmovPercMstpSnonWnonDnon_AcrgPknlMstpSnonWnonDnon_getInMedium {

As author of the ACE_Climb class, this is fine :P

addons/pronelauncher/config.cpp

addons/pronelauncher/functions/fnc_onKeyDown.sqf

commy2

actionKeys is a broken command on my ban list.

addons/pronelauncher/functions/fnc_onKeyDown.sqf

addons/pronelauncher/CfgMovesBasic.hpp

commy2 · 2019-05-21T06:47:21Z

addons/pronelauncher/CfgMovesBasic.hpp

+ class RifleProneActions : RifleBaseStandActions {
+ SecondaryWeapon = "ACE_LauncherProne";
+ weaponOn = "ACE_LauncherProne";
+ weaponOff = "AmovPpneMstpSrasWrflDnon";


Questionale entry. Please explain.

addons/pronelauncher/CfgMovesMaleSdr.hpp

addons/pronelauncher/functions/fnc_onKeyDown.sqf

commy2 · 2019-05-21T06:57:41Z

addons/pronelauncher/CfgMovesMaleSdr.hpp

+ };
+ class LauncherProne_Reload_End: AmovPpneMrunSrasWlnrDf {
+ actions = "ACE_LauncherProneActions";
+ speed = 0.7375;


Out of interest, where are these numbers from? They seem pretty random.

They are, placeholders for when a nicer animation is found.

So what would happen if you just set them to 1 or 0?

AndreasBrostrom · 2021-09-09T21:10:38Z

Standalone release (https://steamcommunity.com/sharedfiles/filedetails/?id=1841047025) have been tested for 2 month in our community. People utalizing it have nothing to complain about or noticed any issues with that implementation.

severgun · 2021-09-10T13:21:23Z

We playing with it for years. It is not common situation when you want to shoot from prone position but crawl quite often. Never heard complains from players too.

PabstMirror · 2021-10-17T03:10:14Z

Should be able to rewrite the actionKey stuff with new 2.06 command

addUserActionEventHandler ["Prone", "Activate", { 
    if ((!alive ACE_player) || {!(isNull objectParent ACE_player)}) exitWith {};
    private _launcherWeapon = secondaryWeapon ACE_player;
    if ((_launcherWeapon == "") || {currentWeapon ACE_player != _launcherWeapon}) exitwith {};

    systemChat "@ prone";
    ACE_player playMoveNow "ACE_LauncherProne";
}];

addUserActionEventHandler ["moveUp", "Activate", { // (X) Crouch / Stand Up
    if ((!alive ACE_player) || {!(isNull objectParent ACE_player)}) exitWith {};
    private _launcherWeapon = secondaryWeapon ACE_player;
    if ((_launcherWeapon == "") || {currentWeapon ACE_player != _launcherWeapon}) exitwith {};

    if ((stance ACE_player) == "PRONE") then {
        systemChat "@ moveUp from prone";
        ACE_player playMoveNow "AmovPpneMstpSrasWlnrDnon_AmovPknlMstpSrasWlnrDnon";
    };
}];

addUserActionEventHandler ["MoveDown", "Activate", { // (Z) Go Prone / Stand Up
    if ((!alive ACE_player) || {!(isNull objectParent ACE_player)}) exitWith {};
    private _launcherWeapon = secondaryWeapon ACE_player;
    if ((_launcherWeapon == "") || {currentWeapon ACE_player != _launcherWeapon}) exitwith {};

    if ((stance ACE_player) == "PRONE") then {
        systemChat "@ moveDown from prone";
        ACE_player playMoveNow "AmovPpneMstpSrasWlnrDnon_AmovPknlMstpSrasWlnrDnon";
        ACE_player playMove "AmovPknlMstpSrasWlnrDnon_AmovPercMstpSrasWlnrDnon";
    } else {
        systemChat "@ moveDown from non-prone";
        ACE_player playMoveNow "ACE_LauncherProne";
    }
}];

The only other issue is the animation speed seems way too fast.
It feels like you can drop to prone about 5 times faster than normal.

Drofseh · 2022-06-05T00:16:01Z

@PiZZAD0X do you plan to continue working on this?

PiZZAD0X · 2022-06-05T00:46:45Z

@PiZZAD0X do you plan to continue working on this?

I am not an animator and I don't mind if anyone wants to modify or add on to this. (or any mod I make) I am very busy with work.

Drofseh · 2022-06-05T02:22:30Z

@PiZZAD0X do you plan to continue working on this?

I am not an animator and I don't mind if anyone wants to modify or add on to this. (or any mod I make) I am very busy with work.

Besides the animations is it complete?

PiZZAD0X · 2022-06-05T03:16:07Z

@PiZZAD0X do you plan to continue working on this?

I am not an animator and I don't mind if anyone wants to modify or add on to this. (or any mod I make) I am very busy with work.

Besides the animations is it complete?

People have been using it for a while and no reported issues as long as they are running it with ACE. It seems functional and stable. Some of the animation timers are a little quick, they were all placeholders.

JonBons · 2022-07-08T21:27:22Z

I've been testing this with a merged version of this PR combined with PabstMirror's script and its been working great.

kymckay · 2022-07-08T21:47:39Z

I've put this on the next release milestone for re-review since it sounds like we could probably get it in.

AndreasBrostrom · 2024-04-04T13:31:37Z

Our community have reported that the back blast cone is aimed to the right instead of the weapon direction.

Unsure if this have been changed or fixed since our test implemention.

I have not tested the current state of this PR if this is resolved. But it can be worth being aware of.

johnb432 · 2024-06-30T10:55:17Z

[...] the back blast cone is aimed to the right instead of the weapon direction.

I can't reproduce with the Mk4 MAAWS nor with several other modded launchers and I can't understand why that would have ever been the case. Overpressure takes the direction of the projectile into account when it does it's backblast calculations. I'll consider this resolved.

AndreasBrostrom · 2024-07-03T06:35:52Z

[...] the back blast cone is aimed to the right instead of the weapon direction.

I'll consider this resolved.

Alright its fair enougth. Might be our implementation that had a bug then. We have not updated the code since Jul 15 2021.

… pr/7002

- Ignore key inputs when in Zeus - Slowed down reloading animation when prone to match "regular" reload time

johnb432

Do we want to rename the states? See https://github.com/acemod/ACE3/pull/7002/files#r284980144.
Imo we should follow updated practices and use the macros to prefix the animations, but I'd like to get more opinions on this.
Need to address https://github.com/acemod/ACE3/pull/7002/files#r285871818 - I have no idea what to think here, hoping people with more knowledge can shed light on the subject.
The transition to prone launcher is way too quick atm. I've tried to slow it down, but I've not managed to implement a way of doing it. I have the impression we need transition animations, but animations are really out of my field of knowledge.
Bug that needs to be fixed: When switching from Binos to Launcher when prone, everything works as intended. But if you switch from Launcher to Binos, it makes the character kneel instead of remaining prone. I tried to fix it, but I didn't manage to.

johnb432 · 2024-07-04T10:18:25Z

addons/pronelauncher/CfgMovesBasic.hpp

+ HandGunOn = "AmovPpneMstpSrasWpstDnon";
+ stance = "ManStanceProne";
+ ReloadRPG = "LauncherProne_Reload_Start";
+ //GestureReloadRPG7[] = {"GestureReloadRPG7Kneel", "Gesture"};


Why is this commented out? If we don't need it, remove it.

johnb432 · 2024-07-04T10:18:45Z

addons/pronelauncher/CfgMovesMaleSdr.hpp

+ // Prone Stopped Launcher -> Standing Stopped Launcher
+ //class AmovPpneMstpSrasWlnrDnon_AmovPercMstpSrasWlnrDnon: TransAnimBase {
+ // actions = "LauncherStandActions";
+ // duty = 2;
+ // enableOptics = 1;
+ // reverse = "AmovPercMstpSrasWlnrDnon_AmovPpneMstpSrasWlnrDnon";
+ // interpolateTo[] += {
+ // "AmovPercMstpSrasWlnrDnon", 0.02
+ // };
+ //};


Same as above.

johnb432 · 2024-07-04T10:19:36Z

addons/pronelauncher/script_component.hpp

+#define COMPONENT_BEAUTIFIED Prone Launcher
+#include "\z\ace\addons\main\script_mod.hpp"
+
+#define DEBUG_MODE_FULL


Before merging:

Suggested change

#define DEBUG_MODE_FULL

// #define DEBUG_MODE_FULL

PiZZAD0X added 3 commits May 16, 2019 09:39

Prone AT Launcher Initial Commit

8350b3b

remove functions

d309e9a

Tab to spaces

f1057b7

jonpas added the kind/feature Release Notes: **ADDED:** label May 16, 2019

jonpas added this to the 3.13.0 milestone May 16, 2019

TheMagnetar reviewed May 16, 2019

View reviewed changes

addons/pronelauncher/XEH_preInit.sqf Outdated Show resolved Hide resolved

TheMagnetar reviewed May 16, 2019

View reviewed changes

addons/pronelauncher/config.cpp Outdated Show resolved Hide resolved

-added addKeyDownHandler function

cd2619a

-removed unnecessary requiredAddons

Dystopian reviewed May 17, 2019

View reviewed changes

PiZZAD0X added 2 commits May 17, 2019 06:43

CBA display EH, Interpolate smoothing for prone -> kneeling

d70693b

FFV keyDown exclusion with CBA_fnc_canUseWeapon

3118196

jonpas requested changes May 17, 2019

View reviewed changes

onKeyDown rewrite, requiredAddons

c26bf3e

PiZZAD0X force-pushed the proneLauncher branch from 11c1402 to c26bf3e Compare May 17, 2019 14:47

PiZZAD0X added 2 commits May 17, 2019 07:53

Tab

47487a2

Remove duplicate stance check

33de8d8

commy2 suggested changes May 21, 2019

View reviewed changes

addons/pronelauncher/functions/fnc_onKeyDown.sqf Outdated Show resolved Hide resolved