Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Use ace_common_fnc_isAwake where possible #10098

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label Jun 30, 2024
@johnb432
Copy link
Contributor Author

johnb432 commented Jun 30, 2024

Quick testing suggests that ACE_isUnconscious isn't changed when killed. I've found a location where this returns inconsistent behaviour:

([_unit] call acre_api_fnc_isSpeaking) && {!(_unit getVariable ["ACE_isUnconscious", false])}

Do we want to switch to EFUNC(common,isAwake) or lifeState == "INCAPACITATED"? I.e should we display sound waves above dead players when they are talking in spectator? Imo it shouldn't and we should switch to EFUNC(common,isAwake).

@johnb432 johnb432 modified the milestone: 3.18.0 Jul 2, 2024
@johnb432 johnb432 merged commit ee0e947 into master Jul 2, 2024
5 checks passed
@johnb432 johnb432 deleted the general-use-isAwake branch July 2, 2024 19:38
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Use `ace_common_fnc_isAwake` where possible

* Revert bad change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants