Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogtags - Code cleanup #10097

Merged
merged 13 commits into from
Jul 20, 2024
Merged

Dogtags - Code cleanup #10097

merged 13 commits into from
Jul 20, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jun 29, 2024

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label Jun 29, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jul 2, 2024
@johnb432 johnb432 merged commit 5d133bd into master Jul 20, 2024
5 checks passed
@johnb432 johnb432 deleted the dogtags-code-cleanup branch July 20, 2024 06:29
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Clean up dogtags

* Only allow taking of dogtags if unit has space

* Fixed upper case T

* Stop throwing error

* Reverted to case insensitive method of checking

* Remove unused files

* More cleanup & fixes

- Better check for taking dog tags until 2.18 comes
- Changed parent condition from `canTakeDogtag` to `canCheckDogtag`
- Register EH only where necessary

* Update CfgEventHandlers.hpp

* More header cleanup
Vdauphin added a commit to Vdauphin/HeartsAndMinds that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants