Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Fixing HighBoost #1152

Merged
merged 2 commits into from
May 3, 2019
Merged

Fixing HighBoost #1152

merged 2 commits into from
May 3, 2019

Conversation

hzawary
Copy link
Contributor

@hzawary hzawary commented Jan 12, 2018

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2018

CLA assistant check
All committers have signed the CLA.

@cesarsouza
Copy link
Member

Hi @hzawary!

Thanks a lot for the contribution!! Before I can accept it, can you please sign the CLA above?

Thanks!!
Cesar

@hzawary
Copy link
Contributor Author

hzawary commented May 13, 2018

Hi @cesarsouza :)

It's done!

Best,
HZ

@fdncred fdncred merged commit e3a7a45 into accord-net:development May 3, 2019
@justingruenberg
Copy link
Contributor

This merge breaks the build.

kernel[size / 2, size / 2] = boost;

Kernel is not accessible from here. Either replace this line with createFilter() or make kernel protected in the Convolution class.

@fdncred
Copy link
Collaborator

fdncred commented May 10, 2019

I'll accept a PR to fix this.

@justingruenberg
Copy link
Contributor

See #1809. Please wait until the CI gets to try it, since I just made the change in the web ui and haven't tested it locally.

fdncred added a commit that referenced this pull request May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants