Skip to content

Commit

Permalink
LibWeb: Correctly calculate height of TableRowGroupBox
Browse files Browse the repository at this point in the history
As well as correctly calculating the height of TableRowBox, this change
calculates the heights of TableRowGroupBoxs also.

As before, this does not correctly take into consideration the 'height'
attribute.

Now the horizontal layout is approximately correct for the
TableRowGroupBoxs we can now see that the `layout_row` method will need
updating to correctly calculate cell width across all rows, not just the
current TableRowGroupBox.
  • Loading branch information
ant1441 authored and awesomekling committed Apr 19, 2021
1 parent ae02acb commit b9c6059
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ void TableFormattingContext::run(Box& box, LayoutMode)

row_group_box.set_height(content_height);

row_group_box.set_offset(0, total_content_height);
total_content_height += content_height;
});

Expand Down

0 comments on commit b9c6059

Please sign in to comment.