Skip to content

Commit

Permalink
Add simplified mmap() and munmap() syscalls.
Browse files Browse the repository at this point in the history
  • Loading branch information
awesomekling committed Oct 24, 2018
1 parent a5caf7c commit 9a296d6
Show file tree
Hide file tree
Showing 13 changed files with 116 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
*.swp
Serenity.config
Serenity.creator
Serenity.creator.user
Serenity.files
Serenity.includes
4 changes: 4 additions & 0 deletions Kernel/Syscall.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ DWORD handle(DWORD function, DWORD arg1, DWORD arg2, DWORD arg3)
return current->sys$getpid();
case Syscall::PosixWaitpid:
return current->sys$waitpid((pid_t)arg1);
case Syscall::PosixMmap:
return (dword)current->sys$mmap((void*)arg1, (size_t)arg2);
case Syscall::PosixMunmap:
return current->sys$munmap((void*)arg1, (size_t)arg2);
case Syscall::PosixExit:
cli();
locker.unlock();
Expand Down
2 changes: 2 additions & 0 deletions Kernel/Syscall.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ enum Function {
PosixGetgid = 0x1992,
PosixGetpid = 0x1993,
PosixWaitpid = 0x1994,
PosixMmap = 0x1995,
PosixMunmap = 0x1996,
};

void initialize();
Expand Down
43 changes: 43 additions & 0 deletions Kernel/Task.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,49 @@ Task::Region* Task::allocateRegion(size_t size, String&& name)
return m_regions.last().ptr();
}

bool Task::deallocateRegion(Region& region)
{
for (size_t i = 0; i < m_regions.size(); ++i) {
if (m_regions[i].ptr() == &region) {
// FIXME: This seems racy.
MemoryManager::the().unmapRegion(*this, region);
m_regions.remove(i);
return true;
}
}
return false;
}

Task::Region* Task::regionFromRange(LinearAddress laddr, size_t size)
{
for (auto& region : m_regions) {
if (region->linearAddress == laddr && region->size == size)
return region.ptr();
}
return nullptr;
}

void* Task::sys$mmap(void* addr, size_t size)
{
// FIXME: Implement mapping at a client-preferred address.
ASSERT(addr == nullptr);
auto* region = allocateRegion(size, "mmap");
if (!region)
return (void*)-1;
MemoryManager::the().mapRegion(*this, *region);
return (void*)region->linearAddress.get();
}

int Task::sys$munmap(void* addr, size_t size)
{
auto* region = regionFromRange(LinearAddress((dword)addr), size);
if (!region)
return -1;
if (!deallocateRegion(*region))
return -1;
return 0;
}

int Task::sys$spawn(const char* path)
{
auto* child = Task::create(path, m_uid, m_gid);
Expand Down
5 changes: 5 additions & 0 deletions Kernel/Task.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ class Task : public InlineLinkedListNode<Task> {
void sys$exit(int status);
int sys$spawn(const char* path);
pid_t sys$waitpid(pid_t);
void* sys$mmap(void*, size_t size);
int sys$munmap(void*, size_t size);

struct
{
Expand Down Expand Up @@ -160,6 +162,9 @@ class Task : public InlineLinkedListNode<Task> {
String name;
};
Region* allocateRegion(size_t, String&& name);
bool deallocateRegion(Region& region);

Region* regionFromRange(LinearAddress, size_t);

Vector<OwnPtr<Region>> m_regions;

Expand Down
Binary file modified Kernel/_fs_contents
Binary file not shown.
1 change: 1 addition & 0 deletions Kernel/sync-sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ mount -o loop _fs_contents mnt/
cp ../Userland/sh mnt/bin/sh
cp ../Userland/id mnt/bin/id
cp ../Userland/ps mnt/bin/ps
cp ../Userland/ls mnt/bin/ls
umount mnt
sync
1 change: 1 addition & 0 deletions LibC/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ OBJS = \
unistd.o \
string.o \
process.o \
mman.o \
entry.o

LIBRARY = LibC.a
Expand Down
16 changes: 16 additions & 0 deletions LibC/mman.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#include "mman.h"
#include <Kernel/Syscall.h>

extern "C" {

void* mmap(void* addr, size_t size)
{
return (void*)Syscall::invoke(Syscall::PosixMmap, (dword)addr, (dword)size);
}

int munmap(void* addr, size_t size)
{
return Syscall::invoke(Syscall::PosixMunmap, (dword)addr, (dword)size);
}

}
10 changes: 10 additions & 0 deletions LibC/mman.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#pragma once

#include "types.h"

extern "C" {

void* mmap(void*, size_t);
int munmap(void*, size_t);

}
1 change: 1 addition & 0 deletions Userland/.gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
id
sh
ps
ls
*.o
9 changes: 7 additions & 2 deletions Userland/Makefile
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
OBJS = \
id.o \
sh.o \
ps.o
ps.o \
ls.o

APPS = \
id \
sh \
ps
ps \
ls

ARCH_FLAGS =
STANDARD_FLAGS = -std=c++17 -nostdinc++ -nostdlib
Expand Down Expand Up @@ -35,6 +37,9 @@ sh: sh.o
ps: ps.o
$(LD) -o $@ $(LDFLAGS) $< ../LibC/LibC.a

ls: ls.o
$(LD) -o $@ $(LDFLAGS) $< ../LibC/LibC.a

.cpp.o:
@echo "CXX $<"; $(CXX) $(CXXFLAGS) -o $@ -c $<

Expand Down
21 changes: 21 additions & 0 deletions Userland/ls.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#include <LibC/stdio.h>
#include <LibC/unistd.h>
#include <LibC/mman.h>

int main(int c, char** v)
{
int fd = open("/");
if (fd == -1) {
printf("failed to open / :(\n");
return 1;
}

byte* memory = (byte*)mmap(nullptr, 16384);
printf("%p\n", memory);
memory[0] = 'H';
memory[1] = 'i';
memory[2] = '!';
memory[3] = '\0';
printf("%p : %s\n", memory, memory);
return 0;
}

0 comments on commit 9a296d6

Please sign in to comment.