Skip to content

Commit

Permalink
Kernel: Disable big process lock in sys$gethostname() sys$sethostname()
Browse files Browse the repository at this point in the history
  • Loading branch information
bgianfo authored and gunnarbeutner committed Jul 20, 2021
1 parent 9201a06 commit 10ce896
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Kernel/API/Syscall.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ enum class NeedsBigProcessLock {
S(get_dir_entries, NeedsBigProcessLock::Yes) \
S(getcwd, NeedsBigProcessLock::Yes) \
S(gettimeofday, NeedsBigProcessLock::Yes) \
S(gethostname, NeedsBigProcessLock::Yes) \
S(sethostname, NeedsBigProcessLock::Yes) \
S(gethostname, NeedsBigProcessLock::No) \
S(sethostname, NeedsBigProcessLock::No) \
S(chdir, NeedsBigProcessLock::Yes) \
S(uname, NeedsBigProcessLock::Yes) \
S(set_mmap_name, NeedsBigProcessLock::Yes) \
Expand Down
4 changes: 2 additions & 2 deletions Kernel/Syscalls/hostname.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extern Mutex* g_hostname_lock;

KResultOr<FlatPtr> Process::sys$gethostname(Userspace<char*> buffer, size_t size)
{
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this)
VERIFY_NO_PROCESS_BIG_LOCK(this)
REQUIRE_PROMISE(stdio);
if (size > NumericLimits<ssize_t>::max())
return EINVAL;
Expand All @@ -27,7 +27,7 @@ KResultOr<FlatPtr> Process::sys$gethostname(Userspace<char*> buffer, size_t size

KResultOr<FlatPtr> Process::sys$sethostname(Userspace<const char*> hostname, size_t length)
{
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this)
VERIFY_NO_PROCESS_BIG_LOCK(this)
REQUIRE_NO_PROMISES;
if (!is_superuser())
return EPERM;
Expand Down

0 comments on commit 10ce896

Please sign in to comment.