Convert any post, that is linked to a vehicle as a page ID, to a perm…

…alink in the 'external URL' field

src/Core.php

@@ -11,7 +11,7 @@
 class Core
 {
  const VERSION = '1.6.7';
- const DB_VERSION = 41;
+ const DB_VERSION = 50;
 
  /**
  * Statische Variable, um die aktuelle (einzige!) Instanz dieser Klasse zu halten

src/Update.php

@@ -3,6 +3,13 @@
 
 use WP_Error;
 use wpdb;
+use function delete_term_meta;
+use function error_log;
+use function get_permalink;
+use function get_post_type;
+use function get_term_meta;
+use function update_option;
+use function update_term_meta;
 
 /**
  *
@@ -75,6 +82,10 @@ public function doUpdate($currentDbVersion, $targetDbVersion)
  if ($currentDbVersion < 41 && $targetDbVersion >= 41) {
  $this->upgrade162();
  }
+
+ if ($currentDbVersion < 50 && $targetDbVersion >= 50) {
+ $this->upgrade170();
+ }
  }
 
  /**
@@ -407,6 +418,33 @@ private function upgrade162()
  update_option('einsatzvw_db_version', 41);
  }
 
+ private function upgrade170()
+ {
+ global $wpdb;
+
+ /**
+ * From now on only pages should be stored in the fahrzeugpid term meta (as it used to be). All other post types
+ * should utilize the new 'external URL' term meta.
+ */
+ $termIds = $wpdb->get_col("SELECT term_id FROM $wpdb->termmeta WHERE meta_key = 'fahrzeugpid' AND `meta_value` != '' AND term_id IN (SELECT term_id FROM $wpdb->term_taxonomy WHERE taxonomy = 'fahrzeug')");
+ foreach ($termIds as $termId) {
+ $postId = get_term_meta($termId, 'fahrzeugpid', true);
+ if (empty($postId) || get_post_type($postId) === 'page') {
+ // Either there is nothing to convert or it's a page (pages are the only post types to remain)
+ continue;
+ }
+
+ // Move anything that is not a page to the 'external URL' field
+ $permalink = get_permalink($postId);
+ if ($permalink !== false) {
+ update_term_meta($termId, 'vehicle_exturl', $permalink);
+ }
+ delete_term_meta($termId, 'fahrzeugpid');
+ }
+
+ update_option('einsatzvw_db_version', 50);
+ }
+
  /**
  * Fügt einen Bezeichner für eine Admin Notice der Liste der noch anzuzeigenden Notices hinzu
  *

tests/integration/UpgradeTest.php

@@ -3,6 +3,13 @@
 
 use WP_UnitTestCase;
 use wpdb;
+use function get_permalink;
+use function get_term_meta;
+use function is_wp_error;
+use function update_option;
+use function update_term_meta;
+use function wp_create_term;
+use function wp_insert_post;
 
 /**
  * Class UpgradeTest
@@ -401,4 +408,40 @@ public function testUpgrade162WithTemplate()
  $this->runUpgrade(40, 41);
  $this->assertTrue('' === get_option('einsatzverwaltung_report_contentifempty'));
  }
+
+ public function testUpgrade170ConvertPageIdToUrl()
+ {
+ // Create some terms for testing
+ $vehicle1 = wp_create_term('Test Vehicle 1', 'fahrzeug');
+ $vehicle1Id = $vehicle1['term_id'];
+ $vehicle2 = wp_create_term('Test Vehicle 2', 'fahrzeug');
+ $vehicle2Id = $vehicle2['term_id'];
+ $postTag = wp_create_term('Some tag');
+ $tagId = $postTag['term_id'];
+
+ // Create some test posts/pages and associate them with the terms
+ $post1Id = wp_insert_post(array('post_type' => 'post', 'post_title' => 'Some post'), true);
+ $pageId = wp_insert_post(array('post_type' => 'page', 'post_title' => 'Some page'), true);
+ $post2Id = wp_insert_post(array('post_type' => 'post', 'post_title' => 'Another post'), true);
+ if (is_wp_error($post1Id) || is_wp_error($pageId) || is_wp_error($post2Id)) {
+ $this->fail('Could not create posts');
+ }
+ update_term_meta($vehicle1Id, 'fahrzeugpid', $post1Id);
+ update_term_meta($vehicle2Id, 'fahrzeugpid', $pageId);
+ update_term_meta($tagId, 'fahrzeugpid', $post2Id);
+
+ $this->runUpgrade(41, 50);
+
+ // Check that the associated post got moved to the external URL field
+ $this->assertEmpty(get_term_meta($vehicle1Id, 'fahrzeugpid', true));
+ $this->assertEquals(get_permalink($post1Id), get_term_meta($vehicle1Id, 'vehicle_exturl', true));
+
+ // Check that the associated page stayed as it was
+ $this->assertEquals($pageId, get_term_meta($vehicle2Id, 'fahrzeugpid', true));
+ $this->assertEmpty(get_term_meta($vehicle2Id, 'vehicle_exturl', true));
+
+ // Check that another taxonomy term with the same term meta did not get changed
+ $this->assertEquals($post2Id, get_term_meta($tagId, 'fahrzeugpid', true));
+ $this->assertEmpty(get_term_meta($tagId, 'vehicle_exturl', true));
+ }
 }