chore: use XDG base dir or platform dirs for config files. Fixes #483. #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined, otherwise use UserConfigDir, UserCacheDir.
os.UserConfigDir()/colima
|
Thanks for this :) |
abiosoft
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add some options for the location of user configuration directories.
As before, use
$HOME/.colimaif it already exists.Otherwise, if the environment variable
XDG_CONFIG_HOMEis set, the Colima configuration directory should be (shell syntax)"${XDG_CONFIG_HOME}"/colima.Likewise, if
XDG_CACHE_HOMEis set, then the cache should be in"${XDG_CACHE_HOME}"/colima.If these variables are not set, use the Go standard lib
os.UserConfigDir()for the configuration:macOS$HOME/Library/Application Support/colimaLinux$HOME/.config/colimaWindows%AppData%\colimaand uses
os.UserCacheDir()for the cache:macOS$HOME/Library/Caches/colimaLinux$HOME/.cache/colimaWindows%LocalAppData%\colimaThis patch addresses #483, and possibly helps #724.