Colima should validate vm-type and mount-type flags

[rfay]

Description

I was working on a recreation scenario for #503 and tried a number of things.

colima start junk --vm-type=qemu --mount-type="" was accepted, but shouldn't a valid mountType be required?

It results in mountType: "" and

$ colima status -p junk
INFO[0000] colima [profile=junk] is running using QEMU
INFO[0000] arch: aarch64
INFO[0000] runtime: docker
INFO[0000] socket: unix:https:///Users/rfay/.colima/junk/docker.sock

(Note that the mountType is not reported there)

But the mountType ends up being 9p, so 9p seems to be the default still on 0.5.2?

But... Unable to recreate the problem described here using this technique.

I was even able to do

• colima start j2 --mount-type="xxx" --vm-type=qemu with no complaint from colima
• and colima start j3 --mount-type="xxx" --vm-type=xxx

I recommend validation on each of those arguments (and all of the rest as well).

I note that manually changing colima.yaml with mountType: yyy and vmType: yyy also results in no validation on start.

colima status -p j3 shows

$ colima status -p j3
INFO[0000] colima [profile=j3] is running using QEMU
INFO[0000] arch: aarch64
INFO[0000] runtime: docker
INFO[0000] mountType: yyy
INFO[0000] socket: unix:https:///Users/rfay/.colima/j3/docker.sock

Apparently it decides QEMU is the thing to do, but it thinks that mountType is yyy.

Version

Colima Version: 0.5.2
Lima Version: 0.14.2
Qemu Version: 7.2.0

Operating System

• macOS Intel <= 12 (Monterrey)
• macOS Intel >= 13 (Ventura)
• macOS M1 <= 12 (Monterrey)
• macOS M1 >= 13 (Ventura)
• Linux

Output of colima status

$ colima status -p j3
INFO[0000] colima [profile=j3] is running using QEMU
INFO[0000] arch: aarch64
INFO[0000] runtime: docker
INFO[0000] mountType: yyy
INFO[0000] socket: unix:https:///Users/rfay/.colima/j3/docker.sock

Reproduction Steps

described above

Expected behaviour

Failure for unsupported vm type or mount type

Additional context

No response