Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile with Go 1.19: imports gvisor.dev/gvisor/pkg/gohacks: build constraints exclude all Go files in (GOPATH)/pkg/mod/gvisor.dev/[email protected]/pkg/gohacks #401

Closed
1 of 3 tasks
AkihiroSuda opened this issue Aug 19, 2022 · 0 comments · Fixed by #402

Comments

@AkihiroSuda
Copy link
Contributor

Description

Can't compile the main branch with Go 1.19

$ go version
go version go1.19 darwin/amd64

$ make
GOOS=darwin GOARCH=amd64 go build -ldflags="-X github.com/abiosoft/colima/config.appVersion=v0.4.4-6-g9ecb817 -X github.com/abiosoft/colima/config.revision=9ecb8171d885b95de4c55d5a029368d5ab29da95" -o _output/binaries/colima-Darwin-x86_64 ./cmd/colima
package github.com/abiosoft/colima/cmd/colima
	imports github.com/abiosoft/colima/cmd
	imports github.com/abiosoft/colima/app
	imports github.com/abiosoft/colima/environment/vm/lima
	imports github.com/abiosoft/colima/daemon
	imports github.com/abiosoft/colima/daemon/process/gvproxy
	imports github.com/containers/gvisor-tap-vsock/pkg/virtualnetwork
	imports github.com/containers/gvisor-tap-vsock/pkg/services/dhcp
	imports github.com/containers/gvisor-tap-vsock/pkg/tap
	imports gvisor.dev/gvisor/pkg/tcpip
	imports gvisor.dev/gvisor/pkg/atomicbitops
	imports gvisor.dev/gvisor/pkg/state
	imports gvisor.dev/gvisor/pkg/state/wire
	imports gvisor.dev/gvisor/pkg/gohacks: build constraints exclude all Go files in /Users/suda/gopath/pkg/mod/gvisor.dev/[email protected]/pkg/gohacks
make: *** [build] Error 1

The offending file: https://github.com/google/gvisor/blob/4f2d380c8b55c49a6eeadd68b0b640b97c0348f7/pkg/gohacks/gohacks_unsafe.go#L15

//go:build go1.13 && !go1.19

Version

Colima Version: 9ecb817

Operating System

  • macOS Intel
  • macOS M1
  • Linux

Reproduction Steps

make

Expected behaviour

Should be compilable

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant