Incorrect detection of overlapping mounts when 1 name is a substring

[neil-greenwood]

colima version 0.2.2
git commit: b2c7697

$ colima start --mount $HOME/.aws/,$HOME/.aws_legacy/,$HOME/.ssh/,$HOME/git:w
INFO[0000] using docker runtime
INFO[0000] starting colima
FATA[0000] error starting vm: overlapping mounts not supported: '/Users/neil/.aws' overlaps '/Users/neil/.aws_legacy'

I would expect this to work, instead of the error message that is displayed.
I guess it might be a problem with lima, not colima itself.

[neil-greenwood]

I tried the .aws_legacy directory with the name .aws-legacy first, and renamed it in case it was a word-separator issue. It still doesn't work when the directory is called .awslegacy.

[jandubois]

See lima-vm/lima#302

[neil-greenwood]

But these don't overlap!

[neil-greenwood]

This was my attempt to workaround lima-vm/lima#302

[jandubois]

Oops, sorry, looks like the check for overlapping mounts is in colima, and is just doing substring matches. So you should try renaming .aws_legacy to .legacy_aws and see if that works.

[neil-greenwood]

That works. So it is the check that is at fault.

[jandubois]

Yes, it is a simple HasPrefix match:

colima/environment/vm/lima/yaml.go

Line 200 in d99e306

if strings.HasPrefix(a, b) || strings.HasPrefix(b, a) {

@abiosoft I would "normalize" the names before comparison by making sure each mount ends with a /.