Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACI IoT Network Traffic Dataset Analysis #669

Merged
merged 12 commits into from
Jun 23, 2024

Conversation

why-aditi
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: ACI IoT Network Traffic Dataset Analysis

Closes: #502

Describe the add-ons or changes you've made 📃

I've implemented 3 models after performing EDA and preprocessing the data

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Tested on 20% of the dataset

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @why-aditi :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the .idea folder.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Jun 19, 2024
@abhisheks008
Copy link
Owner

Need to implement at least 6-7 models for getting the Intermediate tag else this will be considered as Beginner tag.

@why-aditi
Copy link
Contributor Author

Need to implement at least 6-7 models for getting the Intermediate tag else this will be considered as Beginner tag.

I'll implement more models

@why-aditi
Copy link
Contributor Author

Need to implement at least 6-7 models for getting the Intermediate tag else this will be considered as Beginner tag.

I've implemented 6 Models and updated the readme as well. Kindly check

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved @why-aditi

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jun 23, 2024
@abhisheks008 abhisheks008 merged commit da42dfd into abhisheks008:main Jun 23, 2024
@abhisheks008 abhisheks008 added the Points Added 🎉 This issue's points has been added to the leaderboard. label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. Intermediate Points 30 - SSOC 2024 Points Added 🎉 This issue's points has been added to the leaderboard. SSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACI IoT Network Traffic Dataset Analysis
2 participants