if Pack'ing fails the Write fails. Return SERVFAIL.

abh · Sep 4, 2012 · a311f70 · a311f70
1 parent 51f859b
commit a311f70
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/serve.go b/serve.go
@@ -95,9 +95,12 @@ func serve(w dns.ResponseWriter, req *dns.Msg, z *Zone) {
 
  logPrintln(m)
 
- // Ideally you would check the return code here, and perform SERVFAIL in case of
- // an error.
- w.Write(m)
+ err := w.Write(m)
+ if err != nil {
+ // if Pack'ing fails the Write fails. Return SERVFAIL.
+ log.Println("Error writing packet", m)
+ dns.Failed(w, req)
+ }
  return
 }