Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import #75

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix missing import #75

merged 2 commits into from
Dec 21, 2023

Conversation

aazuspan
Copy link
Owner

Close #74 by adding in a missing import for plotly.graph_objects in the timeline method. Also add a test to prevent regression, add 3.12 to the CI, and swap out black and isort in the pre-commit for ruff.

@aazuspan aazuspan added the bug Something isn't working label Dec 21, 2023
@aazuspan aazuspan self-assigned this Dec 21, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c03c2b) 97.44% compared to head (fc9b761) 93.82%.
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   97.44%   93.82%   -3.63%     
==========================================
  Files          20       12       -8     
  Lines        1055      534     -521     
==========================================
- Hits         1028      501     -527     
- Misses         27       33       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aazuspan aazuspan merged commit 362e584 into main Dec 21, 2023
7 of 8 checks passed
@aazuspan aazuspan deleted the fix-go-import branch December 21, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing plotly.graph_objects import in TimeSeries.timeline
2 participants