Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap xarray.open_rasterio for rioxarray.open_rasterio #62 #63

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

aazuspan
Copy link
Owner

@aazuspan aazuspan commented Apr 23, 2023

xarray just dropped the deprecated open_rasterio method (see #62), so this swaps in rioxarray.open_rasterio when calling to_xarray. This is a potentially breaking change because the two methods stored slightly different metadata in the resulting dataset (e.g. ds.crs must now be accessed through ds.rio.crs). More details on differences between the two methods can be found here.

In the process of getting pre-commit checks to pass, we also had to update all the outdated, broken hooks and make a few changes to get mypy passing.

xarray just dropped the deprecated open_rasterio method, so
this swaps in rioxarray.open_rasterio when calling to_xarray.
This is a potentially breaking change because the two methods
stored slightly different metadata in the resulting dataset
(e.g. ds.crs must now be accessed through ds.rio.crs).

In the process of getting pre-commit checks to pass, we also
had to update all the outdated, broken hooks and make a few
changes to get mypy passing.
@codecov-commenter
Copy link

Codecov Report

Merging #63 (ff35fb7) into main (6d6341d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   93.73%   93.75%   +0.01%     
==========================================
  Files          12       12              
  Lines         511      512       +1     
  Branches       53       53              
==========================================
+ Hits          479      480       +1     
  Misses         23       23              
  Partials        9        9              
Impacted Files Coverage Δ
wxee/image.py 86.25% <100.00%> (ø)
wxee/utils.py 100.00% <100.00%> (ø)
wxee/xarray.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aazuspan aazuspan merged commit f174b05 into main Apr 23, 2023
3 checks passed
@aazuspan aazuspan deleted the rioxarray branch April 23, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants