Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default col and groupby kwargs (#57) #58

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Set default col and groupby kwargs (#57) #58

merged 1 commit into from
Oct 18, 2022

Conversation

aazuspan
Copy link
Owner

Closes #57 by allowing user to the override default col="time" arg for static rgb plots. Also specifies a default groupby="time" kwarg for interactive plots.

@aazuspan aazuspan added the enhancement New feature or request label Oct 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #58 (06d509c) into main (f171265) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   93.76%   93.73%   -0.03%     
==========================================
  Files          12       12              
  Lines         513      511       -2     
  Branches       67       53      -14     
==========================================
- Hits          481      479       -2     
  Misses         23       23              
  Partials        9        9              
Impacted Files Coverage Δ
wxee/xarray.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aazuspan
Copy link
Owner Author

The 3.7 build failure is unrelated to this change (see #59).

@aazuspan aazuspan merged commit 70571f7 into main Oct 18, 2022
@aazuspan aazuspan deleted the rgb_col branch April 25, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding col in rgb method
2 participants