Fix bug when all classes are hidden #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiding all classes would throw an exception related to mismatched data types during some internal update of the widget state. I traced that back to the `SankeyPlot.plot.data[0].link` update and found it broke if you used the link data from a `go.Sankey` that was initialized with `link_kwargs`. Instead, intitializing with an empty `go.Sankey` seems to solve the issue. That only arises if all classes are hidden, so I just threw in an early return of an empty `go.Sankey` in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is a bug fix for when all classes are manually hidden in the interactive FigureWidget. See 8d5bfbf.
This also contains a number of maintenance updates like making methods private and deprecating the unused
excludearg.