Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/249 markets with more assets #251

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Fix/249 markets with more assets #251

merged 2 commits into from
Nov 29, 2021

Conversation

LHerskind
Copy link
Contributor

This PR add support for > 128 reserves for new deployments of the Aave protocol by setting a higher limit before deployment. The limit must be set as a literal in DataTypes::UserConfigurationMap and in UserConfiguration.

Closes #249

@LHerskind
Copy link
Contributor Author

The id of the reserve is currently uint8, needs to be increased to support >256 assets. If not, assets can hit the same id as uint8(256)=0 etc.

@kartojal kartojal merged commit e558db4 into master Nov 29, 2021
@kartojal kartojal mentioned this pull request Jan 10, 2022
Merged
@LHerskind
Copy link
Contributor Author

Note: As this extension update the layout of UserConfigurationMap integrations using the old UserConfigurationMap to retrieve the new or vice-verse will break. Also, be aware that upgrading an existing deployment to this extension will mess up your storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartojal kartojal kartojal approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow dynamic asset limit to support markets with more than 128 assets
2 participants
@LHerskind @kartojal