Callback token key changes after invalidating it. (after every update actually)

[thetarby]

Because of the pre_save signal which checks whether a token with the same key already exists and recreates key if that is the case, after each save call on a callback token its key value changes. That is not good because even after invalidating a token its key value could be useful and also it requires an unnecessary db hit which is bad for performance.

To solve the problem, in pre_save handler first check if save is called to update an already existing token or it is called to create a new one. If it is called to update it then don't check for key's uniqueness.

[gozdecoban]

Hi Aaron, do you consider merging this? I have the same issue.

[aaronn]

Okay, I'll look into this this week.

[aaronn]

I think we actually need a migration for this too:

unique_together = (('key', 'is_active'),)

Because of this bit, any older keys with is_active=False will collide.

Edit: Actually I suppose this migration can be done separately.