Demo Users #56
Merged
Demo Users #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budlight
force-pushed
the
master
branch
2 times, most recently
from
3058a2d
to
c63bd59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the user to add demo users like:
where 1 is the primary_key of the user and '123456' is a static pin.
I based this off of https://github.com/charleshan/django-rest-framework-passwordless/commits/master
I think we could instead add a field that is evaluated as bool similar to PASSWORDLESS_USER_MOBILE_VERIFIED_FIELD_NAME and have it set which users are demo users. Both ways really have different downsides and upsides. A demo user pretty much has to be a permanent user with Apple.
Let me know if you have any input.
This is in references to #45