Mac support #5
Merged
Mac support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As commented in #1, `bash` is not always in `/bin`, particularly on non-Linux systems (as covered in [1]). This new shebang searches PATH for `bash` and should use the first `bash` found (hopefully is the newest) [1]: https://stackoverflow.com/a/21613044/3281097 Signed-off-by: Antonio Ossa Guerra <[email protected]>
On BSD-related environment (mostly related to Mac OS) the default `date` does not point to the GNU date version that this script expects. So, we'll check if the available `date` command is GNU date, if that's not the case we'll try to use `gdate`, from `coreutils`, and raise an exception if none of them is available. This behaviour was reported in #1 Signed-off-by: Antonio Ossa Guerra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issues mentioned in #1 . Introduces a new shebang that should map to the newest version of bash available. Also checks if the available
datecommand is GNU date, if that's not the case tries to usegdate, and if that's not the case it ends with an error and a message about installingcoreutils.