fix ratio when set to “container” #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting `ratio` to `container` has broken since the ratio alogrithm was fixed. When set to `container` it would use the old ratio algorithim to set the ratio. This PR changes it so that it uses the correct algorithim based on wether or not `traditionalRatio` is set
tikotzky
changed the title
|
Thanks! |
|
Thank you |
|
@aFarkas any timeline on publishing this PR? |
|
give me a week |
|
sorry it took longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting
ratiotocontainerhas broken since the ratio alogrithm was fixed.When set to
containerit would use the old ratio algorithim to set the ratio.This PR changes it so that it uses the correct algorithim based on wether or not
traditionalRatiois set