Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined terminated https listener code #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanaA10networks
Copy link

Description

If Feature Addition:

  • Required: Related user story

If Bug Fix:

  • Required: Severity Level (Low, High, Critical)
  • Required: Issue Description

Jira Ticket

This is optional if you are an external contributor

  • Required: Add links to tickets closed here

Technical Approach

  • Required: Overview of approach taken to solve the problem
  • Optional: List of tasks completed w/ links

Config Changes

This is only required if the config has been updated in this PR

  • Required: Provide example config snippet within pre block
Add changes in bold

(Example Snippet - Remove This Before Submission)

[rack_vthunder]

devices=[
 {
 "project_id": "fake_uuid",
 "username" : "username",
 "password" : "password",
 "ip_address" : "10.43.12.137",
 "device_name" : "rack_1"
 "example": "change",
 },
 }]

Test Cases

  • Required: List edge cases tested against in unit tests

Manual Testing

  • Required: List of steps to manually test feature or fix

@sanaA10networks sanaA10networks marked this pull request as draft May 2, 2024 09:33
@sanaA10networks sanaA10networks marked this pull request as ready for review May 2, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants