move GetMembersOnThunder and CountMembersOnThunderBySubnet tasks to d… #612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…elete_member_vrid_subflow (which we do not use) because they're slow
I believe the main cause for slowness is that a database session is established for each member:
a10-octavia/a10_octavia/controller/worker/tasks/a10_database_tasks.py
Line 1257 in be28b21
While this db session could likely be reused and therefore speed up the task, I believe it's also unnecessary to perform this task as part of the get_rack_vthunder_delete_member_flow.
Tasks are added to get_rack_vthunder_delete_member_flow even though the constants they provide are not used in this flow.
a10-octavia/a10_octavia/controller/worker/flows/a10_member_flows.py
Lines 411 to 421 in be28b21
Instead, the a10constants.MEMBER_COUNT_THUNDER constant is used in the get_delete_member_vrid_subflow. Moving these tasks to the relevant flow significantly speeds up member deletion for us.
a10-octavia/a10_octavia/controller/worker/flows/a10_member_flows.py
Line 573 in be28b21