Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move GetMembersOnThunder and CountMembersOnThunderBySubnet tasks to d… #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spencerharmon
Copy link

…elete_member_vrid_subflow (which we do not use) because they're slow

I believe the main cause for slowness is that a database session is established for each member:

While this db session could likely be reused and therefore speed up the task, I believe it's also unnecessary to perform this task as part of the get_rack_vthunder_delete_member_flow.

Tasks are added to get_rack_vthunder_delete_member_flow even though the constants they provide are not used in this flow.

delete_member_flow.add(
a10_network_tasks.GetMembersOnThunder(
requires=[a10constants.VTHUNDER, a10constants.USE_DEVICE_FLAVOR],
provides=a10constants.MEMBERS))
delete_member_flow.add(
a10_database_tasks.CountMembersOnThunderBySubnet(
requires=[
constants.SUBNET,
a10constants.USE_DEVICE_FLAVOR,
a10constants.MEMBERS],
provides=a10constants.MEMBER_COUNT_THUNDER))

Instead, the a10constants.MEMBER_COUNT_THUNDER constant is used in the get_delete_member_vrid_subflow. Moving these tasks to the relevant flow significantly speeds up member deletion for us.

a10constants.MEMBER_COUNT_THUNDER],

…elete_member_vrid_subflow (which we do not use) because they're slow
@ytsai-a10
Copy link
Collaborator

@spencerharmon
Apricated for providing this enhancement. The patch looks good to us.
But since currently we don't have resource to verify this patch, so can you help provide some testing detail? For example, test cases, results, logs...etc. Otherwise, it may take some time for us to schedule resource for this verification or automation testing.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants