Glitchy Geometry for road

[Zaneo]

Way: https://www.openstreetmap.org/way/114559247

I do not expect any action on this, I just wanted to point out a case where there was something funny going on.

[dabreegster]

To repro easily, geojson is:

{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {},
      "geometry": {
        "type": "Polygon",
        "coordinates": [
          [
            [
              139.71793055534363,
              35.58628785038091
            ],
            [
              139.7271680831909,
              35.58628785038091
            ],
            [
              139.7271680831909,
              35.59249116981333
            ],
            [
              139.71793055534363,
              35.59249116981333
            ],
            [
              139.71793055534363,
              35.58628785038091
            ]
          ]
        ]
      }
    }
  ]
}

Look for lane 1763.

Something very funny is going on with OSM here... try clicking the intersections at either end and jumping to the OSM nodes. I get https://www.openstreetmap.org/node/1297431637#map=19/35.58856/139.72453 and https://www.openstreetmap.org/node/2071014569#map=19/35.58835/139.72473, but that second one isn't a member of the way

[dabreegster]

Actually wait, this is the classic problem with curved roads that have lots of points:

I manually removed some of the points with the RawMap editor and the problem cleared up. I literally made some changesets the other day to fix a similar problem elsewhere. @michaelkirk suggested using https://docs.rs/geo/latest/geo/algorithm/simplify/trait.Simplify.html to do this automatically, which would be way less of a hassle.

I'll try this out!

[dabreegster]

It's looking like an easy win! I'll regenerate all maps with this line simplification, then push through the change

[dabreegster]

Another example of a fix from the screenshot test in Kennington, London. Before:

After:

The fix will be merged momentarily, in next Sunday's build, or you can try it asap if you're building from source.

Thanks for raising this issue and urging a proper fix!