VoxelStreamRegionFiles does not load the saved data

[matthewhilton]

Describe the bug

• A blocky terrain is set up with a VoxelStreamRegionFiles pointing at a directory
• Some edits are made to the terrain
• save_modified_blocks is called, and the region files are successfully saved (visible in file browser)
• Upon game reload, the edits made are not loaded

To Reproduce
See above or use this test project
In the test project, press E to make an edit, and then R to save.
VoxelSaveLoadTest.zip

Expected behavior
I assume since there are no load methods, that the region loads the data automatically. However, the saved edits do not appear to load.

Debugging
I did some prodding around in the source and believe this is being hit, indicating the region cache is not loading correctly

godot_voxel/streams/region/voxel_stream_region_files.cpp

Lines 172 to 174 in 2acfab8

	case ERR_DOES_NOT_EXIST:
	return EMERGE_OK_FALLBACK;

Environment

• OS: Windows 10
• Graphics card: Vulkan API 1.3.242 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce GTX 1060 3GB
• Godot version & Module version: 4.1.1 - am on the release https://github.com/Zylann/godot_voxel/releases/tag/v1.1.0
• Renderer used: Forward+

[Zylann]

Is this happening too if you reproduce this without the editor being open too? Haven't looked into it yet but my first suspicion is that if your scene is open in the editor, some files might be locked by it and the running game might be prevented from opening them by the OS (same with #597).
Another way to test that is by setting up the stream by script instead of having it in the editor, or turning off run_stream_in_editor.

Another possibility depending on how big your cube actually is, is that it simply didnt finish saving when you quit. Using graceful closing with the window's Close button should normally work fine, but if you use Godot's Stop button in the editor, that kills the game's process, leading to incomplete saving.

[Zylann]

I just tested a first time in my dev branch, the map loaded correctly.

Tested 3 more times, each time the game loads fine.
Tested 3 more times using the 4.1.1 build. Still loaded fine. And I'm on Windows 10 too so that setup is exactly the same.
I can't reproduce your issue.

issue596_cant_repro.mp4