Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Coverage version explicitly. #987

Merged
merged 2 commits into from
Oct 1, 2019

Conversation

Julian-O
Copy link
Contributor

@Julian-O Julian-O commented Jul 16, 2019

The Travis builds have been broken for about 4 weeks.

I didn't fully explore the reasons, but Coverage 5.0a5 (an alpha version) was being installed, and then clashing with the Coverall which required version <5.0.

As a result, the Travis tests were not being run.

Adding a specific requirement for coverage solved the problem.


Also removed a deprecated parameter from pytest.raises(), which was leading to lots of deprecation warnings in the tests. [Sorry - should have been two branches, but they got mised together. The changes are trivial.]

  • [N/A] If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • [N/A ] I have added a test to the test suite, if necessary
  • [N/A] I have properly documented new or changed features in the documention, or the docstrings
  • [N/A] I have properly documented unusual changes to the code in the comments around it
  • [N/A] I have made note of any breaking/backwards incompatible changes

Attempting to stop 5.0a5 from being installed.
Use of the message parameter is now deprecated.
See pytest-dev/pytest#397
Removed to reduce warnings when tests run.
@Julian-O Julian-O mentioned this pull request Jul 17, 2019
5 tasks
@tburrows13
Copy link
Collaborator

Thank you very much for tracking this down. It seems to do the job!

@tburrows13 tburrows13 merged commit 26d7858 into Zulko:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants