Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: rename set_merge_cell to merge_cell #74

Merged
merged 3 commits into from
Jun 2, 2024
Merged

Conversation

Zncl2222
Copy link
Owner

@Zncl2222 Zncl2222 commented Jun 2, 2024

No description provided.

@Zncl2222 Zncl2222 added this to the v0.0.8 milestone Jun 2, 2024
@Zncl2222 Zncl2222 self-assigned this Jun 2, 2024
Copy link

codacy-production bot commented Jun 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.16% (target: -5.00%) 85.71%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f047488) 990 963 97.27%
Head commit (a70f825) 1003 (+13) 974 (+11) 97.11% (-0.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#74) 14 12 85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.10%. Comparing base (f047488) to head (a70f825).

Files Patch % Lines
pyfastexcel/workbook.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   97.25%   97.10%   -0.16%     
==========================================
  Files          14       14              
  Lines        1057     1070      +13     
==========================================
+ Hits         1028     1039      +11     
- Misses         20       22       +2     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zncl2222 Zncl2222 added the style rename var or function or adjust coding style label Jun 2, 2024
@Zncl2222 Zncl2222 merged commit 77c2a78 into main Jun 2, 2024
22 checks passed
@Zncl2222 Zncl2222 deleted the style/merge_cell_rename branch June 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor style rename var or function or adjust coding style test unittest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants