Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: save function for workbook #36

Merged
merged 3 commits into from
Apr 28, 2024
Merged

Feat: save function for workbook #36

merged 3 commits into from
Apr 28, 2024

Conversation

Zncl2222
Copy link
Owner

No description provided.

@Zncl2222 Zncl2222 added documentation Improvements or additions to documentation enhancement New feature or request test unittest labels Apr 28, 2024
@Zncl2222 Zncl2222 added this to the v0.0.6 milestone Apr 28, 2024
@Zncl2222 Zncl2222 self-assigned this Apr 28, 2024
Copy link

codacy-production bot commented Apr 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 95.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4a1e8fe) 698 689 98.71%
Head commit (e171023) 718 (+20) 709 (+20) 98.75% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#36) 40 38 95.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.89%. Comparing base (4a1e8fe) to head (e171023).

Files Patch % Lines
pyfastexcel/driver.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   98.85%   98.89%   +0.03%     
==========================================
  Files           7        8       +1     
  Lines         701      721      +20     
==========================================
+ Hits          693      713      +20     
  Misses          6        6              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zncl2222 Zncl2222 merged commit 4b592e3 into main Apr 28, 2024
22 checks passed
@Zncl2222 Zncl2222 deleted the feature/save branch April 28, 2024 04:33
@Zncl2222 Zncl2222 linked an issue Apr 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request test unittest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FastWriter and NormalWriter easier to use
2 participants