Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor&Feat: style validation and row_append rework #32

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

Zncl2222
Copy link
Owner

No description provided.

@Zncl2222 Zncl2222 added enhancement New feature or request test unittest refactor labels Apr 13, 2024
@Zncl2222 Zncl2222 added this to the v0.0.6 milestone Apr 13, 2024
@Zncl2222 Zncl2222 self-assigned this Apr 13, 2024
Copy link

codacy-production bot commented Apr 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.12% (target: -1.00%) 96.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ff675e7) 643 635 98.76%
Head commit (7d941a2) 661 (+18) 652 (+17) 98.64% (-0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#32) 25 24 96.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.79%. Comparing base (ff675e7) to head (7d941a2).

Files Patch % Lines
pyfastexcel/utils.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   98.91%   98.79%   -0.13%     
==========================================
  Files           7        7              
  Lines         646      664      +18     
==========================================
+ Hits          639      656      +17     
- Misses          5        6       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zncl2222 Zncl2222 merged commit ef4990d into main Apr 13, 2024
22 checks passed
@Zncl2222 Zncl2222 deleted the refactor/row_append_style branch April 13, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor test unittest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants