Convert deprecated listpeer usage to listpeerchannels #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple `listpeers` uses can remain because they don't need channel information. Others use ListpeersAnnouncer and are covered by the next commit.
Construct a "compatibility struct" to convert `listpeerchannels` output into legacy `listpeers` format. Tests written using the legacy listpeers format can use the `convert_legacy_listpeers` utility to construct a compatibility struct. The test_peerjudge_datagatherer malformed test needed to be malformed differently to achieve the desired effect.
|
Testing on mutinynet |
chrisguida
reviewed
May 25, 2024
| std::ostream& operator<<(std::ostream& os, Boss::Mod::ConstructedListpeers const& o) { | ||
| for (auto p : o) { | ||
| os << p.first << ':' | ||
| << "connected: " << p.second.connected |
There was a problem hiding this comment.
curious what this second does
There was a problem hiding this comment.
access the (key, vale) in c++ is (first, second)
I bet that ConstructedListpeers is a map
There was a problem hiding this comment.
Ah cool. How can I verify this? Struggling to find the definition of ConstructedListpeers
There was a problem hiding this comment.
What I do usually is git grep -n "ConstructedListpeers" and then search inside the result
In this case, I found the following line Boss/Mod/ConstructedListpeers.hpp:24:typedef std::map<Ln::NodeId, ConstructedListpeer> ConstructedListpeers;
There was a problem hiding this comment.
Ahh, thanks!! Still getting familiar with how C++ does things...
|
rebased and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct a "compatibility struct" to convert
listpeerchannelsoutput into a "virtual" legacylistpeersformat.This maintains the semantics of all of the use sites which currently traverse peer, then channel to make decisions and take actions.
Tests written using the legacy listpeers format can use the
convert_legacy_listpeersutility to construct a compatibility struct.The
test_peerjudge_datagatherermalformed test needed to be malformed differently to achieve the desired effect.