Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on startup when --developer used #185

Closed
ksedgwic opened this issue Dec 6, 2023 · 8 comments
Closed

Crash on startup when --developer used #185

ksedgwic opened this issue Dec 6, 2023 · 8 comments

Comments

@ksedgwic
Copy link
Collaborator

ksedgwic commented Dec 6, 2023

version:
lightningd: v23.11-14-g2f5f098-modded (VLS build on v23.11)

relevant config:

log-level=info
clboss-auto-close=true
important-plugin=/usr/local/bin/clboss
developer

result:

Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:24.681Z INFO    lightningd: v23.11-14-g2f5f098-modded
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.278Z DEBUG   lightningd: Opened log file -
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.278Z DEBUG   lightningd: Opened log file /home/cln/.lightning/testnet/lightning.log
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.305Z DEBUG   plugin-manager: started(669961) /usr/local/libexec/c-lightning/plugins/autoclean
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.345Z DEBUG   plugin-manager: started(669962) /usr/local/libexec/c-lightning/plugins/chanbackup
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.370Z DEBUG   plugin-manager: started(669963) /usr/local/libexec/c-lightning/plugins/bcli
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.395Z DEBUG   plugin-manager: started(669964) /usr/local/libexec/c-lightning/plugins/commando
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.422Z DEBUG   plugin-manager: started(669968) /usr/local/libexec/c-lightning/plugins/fetchinvoice
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.447Z DEBUG   plugin-manager: started(669969) /usr/local/libexec/c-lightning/plugins/funder
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.471Z DEBUG   plugin-manager: started(669970) /usr/local/libexec/c-lightning/plugins/topology
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.496Z DEBUG   plugin-manager: started(669971) /usr/local/libexec/c-lightning/plugins/keysend
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.519Z DEBUG   plugin-manager: started(669972) /usr/local/libexec/c-lightning/plugins/offers
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.551Z DEBUG   plugin-manager: started(669973) /usr/local/libexec/c-lightning/plugins/pay
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.589Z DEBUG   plugin-manager: started(669974) /usr/local/libexec/c-lightning/plugins/txprepare
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.619Z DEBUG   plugin-manager: started(669975) /usr/local/libexec/c-lightning/plugins/cln-renepay
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.647Z DEBUG   plugin-manager: started(669976) /usr/local/libexec/c-lightning/plugins/spenderp
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.686Z DEBUG   plugin-manager: started(669977) /usr/local/libexec/c-lightning/plugins/sql
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.713Z DEBUG   plugin-manager: started(669978) /usr/local/libexec/c-lightning/plugins/cln-grpc
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.738Z DEBUG   plugin-manager: started(669980) /usr/local/libexec/c-lightning/plugins/bookkeeper
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.762Z DEBUG   plugin-manager: started(669981) /usr/local/libexec/c-lightning/plugins/clnrest/clnrest.py
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.813Z DEBUG   plugin-manager: started(669982) /usr/local/bin/clboss
Dec 06 13:38:25 home4 vlsd2[669957]: [2023-12-06 21:38:25.853 vlsd2/vls_proxy::grpc::signer WARN] error connecting to node, will retry: transport error - error trying to connect: tcp connect error: Connection refused (os error 111)
Dec 06 13:38:25 home4 lightningd[669956]: 2023-12-06T21:38:25.886Z DEBUG   plugin-manager: started(669983) /usr/local/src/plugins/summary/summary.py
Dec 06 13:38:25 home4 lightningd[669956]: lightningd: FATAL SIGNAL 11 (version v23.11-14-g2f5f098-modded)
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c802e1f0a send_backtrace
Dec 06 13:38:26 home4 lightningd[669956]:         common/daemon.c:33
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c802e20f5 crashdump
Dec 06 13:38:26 home4 lightningd[669956]:         common/daemon.c:75
Dec 06 13:38:26 home4 lightningd[669956]: 0x7f379504251f ???
Dec 06 13:38:26 home4 lightningd[669956]:         ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c8029d1c5 plugin_conn_finish
Dec 06 13:38:26 home4 lightningd[669956]:         lightningd/plugin.c:875
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c80475970 destroy_conn
Dec 06 13:38:26 home4 lightningd[669956]:         ccan/ccan/io/poll.c:246
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c80475994 destroy_conn_close_fd
Dec 06 13:38:26 home4 lightningd[669956]:         ccan/ccan/io/poll.c:252
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c8048548f notify
Dec 06 13:38:26 home4 lightningd[669956]:         ccan/ccan/tal/tal.c:246
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c80485a70 del_tree
Dec 06 13:38:26 home4 lightningd[669956]:         ccan/ccan/tal/tal.c:437
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c80485e16 tal_free
Dec 06 13:38:26 home4 lightningd[669956]:         ccan/ccan/tal/tal.c:521
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c80473ebb io_close
Dec 06 13:38:26 home4 lightningd[669956]:         ccan/ccan/io/io.c:450
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c804760fa io_loop
Dec 06 13:38:26 home4 lightningd[669956]:         ccan/ccan/io/poll.c:457
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c80260da5 io_loop_with_timers
Dec 06 13:38:26 home4 lightningd[669956]:         lightningd/io_loop_with_timers.c:22
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c802a0986 plugins_init
Dec 06 13:38:26 home4 lightningd[669956]:         lightningd/plugin.c:1991
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c80267fd6 main
Dec 06 13:38:26 home4 lightningd[669956]:         lightningd/lightningd.c:1082
Dec 06 13:38:26 home4 lightningd[669956]: 0x7f3795029d8f __libc_start_call_main
Dec 06 13:38:26 home4 lightningd[669956]:         ../sysdeps/nptl/libc_start_call_main.h:58
Dec 06 13:38:26 home4 lightningd[669956]: 0x7f3795029e3f __libc_start_main_impl
Dec 06 13:38:26 home4 lightningd[669956]:         ../csu/libc-start.c:392
Dec 06 13:38:26 home4 lightningd[669956]: 0x560c8022dc84 ???
Dec 06 13:38:26 home4 lightningd[669956]:         ???:0
Dec 06 13:38:26 home4 lightningd[669956]: 0xffffffffffffffff ???
@tsjk
Copy link

tsjk commented Jan 10, 2024 •
edited
Loading

Does it work if you specify both --developer and --allow-deprecated-apis=true (in that order - supposedly the latter will override the former's turning the depricated apis off)?

@tsjk
Copy link

tsjk commented Jan 10, 2024

I still run v23.08.1, but am looking to upgrade. This bug report has put me off a bit, though.

@tsjk
Copy link

tsjk commented Jan 24, 2024

I couldn't find a way to run v23.11.2 with both clboss and --developer. I'll have to do without the latter for the time being.

@har15eld0n
Copy link

har15eld0n commented Feb 11, 2024 •
edited
Loading

Same here, I had to disable clboss to activate the developer mode, and do my thing (running: lightning-cli dev-rescan-outputs)
Reactivated the plugin, when I was done...

NOTE: I tried with --allow-deprecated-apis=true and it did not improve the situation...

@Kexkey
Copy link

Kexkey commented Feb 12, 2024

Might have something to do with this: https://github.com/ElementsProject/lightning/blob/v23.11.2/doc/lightning-listpeers.7.md#return-value

- channels (array of objects, optional) deprecated, removal in v23.11:

For some reason, channels in the listpeers response is still there when developer mode is OFF. It has been removed (as announced in the doc) when it is ON, though.

@tsjk
Copy link

tsjk commented Feb 13, 2024

When developer mode is off deprecated apis are enabled. That's why you have channels there in listpeers.
Of course clboss ought be updated to not need deprecated apis, but a plausible workaround for it not working with developer mode was to also enable deprecated apis. This however seems not to work.

ksedgwic added a commit to ksedgwic/clboss that referenced this issue Jun 15, 2024
@ksedgwic
Recognize --developer CLI flag and don't exit giving usage ([ZmnSCP…
17667a4 
…xj#185])

CLBOSS did not know the `--developer` flag and generated a usage
message and exited.  Fixed with:
- recognize and consume the `developer` flag, no actions for now
- print unrecognized options to std::cerr

Fixes ([ZmnSCPxj#185])
ksedgwic added a commit to ksedgwic/clboss that referenced this issue Jun 15, 2024
@ksedgwic
Recognize --developer CLI flag and don't exit giving usage ([ZmnSCP…
e839c2a 
…xj#185])

CLBOSS did not know the `--developer` flag and generated a usage
message and exited.  Fixed with:
- recognize and consume the `developer` flag, no actions for now
- print unrecognized options to std::cerr

Fixes ([ZmnSCPxj#185])
@ksedgwic ksedgwic mentioned this issue Jun 15, 2024
Merged
@ksedgwic
Copy link
Collaborator Author

It was as simple as clboss didn't know the --developer flag and was exiting w/ usage ... #216

ksedgwic added a commit that referenced this issue Jun 17, 2024
@ksedgwic
Recognize --developer CLI flag and don't exit giving usage ([#185])
a8ca8ca 
CLBOSS did not know the `--developer` flag and generated a usage
message and exited.  Fixed with:
- recognize and consume the `developer` flag, no actions for now
- print unrecognized options to std::cerr

Fixes ([#185])
@ksedgwic
Copy link
Collaborator Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ksedgwic @tsjk @Kexkey @har15eld0n