Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in compilation of tests #460

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Jun 25, 2024

Adding Wall and Wextra flags to the compilation of tests a lot of warnings popped out. This PR fixes them.
I think that this might also fix issue #311.

@sbaldu sbaldu requested a review from ZigRazor June 25, 2024 10:59
@sbaldu sbaldu changed the title Fix compilation warnings Fix warnings in compilation of tests Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (1057808) to head (5d17fd9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files          87       87              
  Lines       10085    10080       -5     
  Branches      670      670              
==========================================
- Hits         9872     9867       -5     
  Misses        213      213              
Flag Coverage Δ
unittests 97.88% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZigRazor ZigRazor linked an issue Jun 25, 2024 that may be closed by this pull request
1 task
@ZigRazor ZigRazor merged commit 23cd6d9 into ZigRazor:master Jun 25, 2024
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Multiplication result converted to larger type
2 participants