Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]v1.3.3 plan: add more configuire file | add scope filter options | support read promise Func options #30

Closed
Zhengqbbb opened this issue May 23, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request next version Plan for next version

Comments

@Zhengqbbb
Copy link
Owner

Zhengqbbb commented May 23, 2022

💭 Describe the feature

  1. Add more configuire file and support custom define config file path
  • .cz.js
  • cz.config.js
  1. Add scope filter options

  2. Add typesDefault options

  3. Support read promise Func options


💡 Proposed Solution

Add more js configuire file

💡 Inspiration by :commitizen/cz-cli#460 | commitizen/cz-cli#888 | commitizen/cz-cli#773

Add scope filter options

💡 Inspiration by :Tencent/tdesign-vue-next#847

  • It was found in the PR that some system files should be automatically hidden.e.g .DS_Store
  • And the user can also customize the filter value
  • This value should be the target value attribute

Add typesDefault options

💡 Inspiration by :vuepress-next

  • In some processing of the project containing documents, if there is a modification of the docs in the git status, then it should be able to top

Support read promise Func options

💡 Inspiration by :

https://github.com/element-plus/element-plus/blob/1a19b43b19af5be0fb3828b2cb320d19097762eb/commitlint.config.js#L5-L13

  • Use pnpm package - @pnpm/find-workspace-packages can get monorepo items info
  • It nice util Func but it is async Fuc
  • current cz-git options need supoort handling asynchronous functions dynamically
@Zhengqbbb Zhengqbbb added enhancement New feature or request next version Plan for next version labels May 23, 2022
@Zhengqbbb Zhengqbbb self-assigned this May 23, 2022
@Zhengqbbb Zhengqbbb changed the title [Feature Request]v1.2.4 plan: add more configuire file | add scope filter options | support read promise Func options [Feature Request]v1.3.3 plan: add more configuire file | add scope filter options | support read promise Func options May 23, 2022
@Zhengqbbb
Copy link
Owner Author

Zhengqbbb commented May 27, 2022

Tested, using @pnpm/find-workspace-packages takes close to 300ms. It is not recommended to use this package for query

Zhengqbbb added a commit that referenced this issue May 27, 2022
Zhengqbbb added a commit that referenced this issue May 27, 2022
it will pin type item the top of the types list (if match item value)

link #30
Zhengqbbb added a commit that referenced this issue May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next version Plan for next version
Projects
None yet
Development

No branches or pull requests

1 participant