Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tor v3 patch #114

Closed
wants to merge 7 commits into from

Conversation

zolagonano
Copy link

@zolagonano zolagonano commented Dec 24, 2021

Tor doesn't support Onion domains V2 anymore, so there was no need for RSA being in dependencies and supporting Onion V2 in CryptRsa.
So, I removed support of Onion V2 and renamed CryptRsa into CryptTor.
Also, I Moved CryptEd25519 into libraries.

Edit: I had to replace CryptRsa with CryptTor in some plugins, so I opened another PR in ZeroNetX/Zeronet-Plugins (ZeroNetX/ZeroNet-Plugins#1).

@zolagonano
Copy link
Author

I tested it and it's working just fine.

@canewsin
Copy link
Collaborator

Ok, Some pit holes here
I think removing rsa breaks functionality of verifying data signed by unpatched clients. Also signing with v3 keys are can't verifiable by unpatched clients.

@zolagonano
Copy link
Author

Ok, Some pit holes here I think removing rsa breaks functionality of verifying data signed by unpatched clients. Also signing with v3 keys are can't verifiable by unpatched clients.

But, the unpatched clients cannot even connect to the Tor network because The Tor project has stopped the support of Onion Service V2 (which needed RSA). There is no need for verifying unpatched clients because there is no client with Onion Service V2.

Also, The RSA in dependencies is just used by CryptRsa which doesn't have anything to do with signing/verifying data, sslcrypto (which is used to encrypt connections with SSL-TLS) has its own RSA in the lib directory, so it doesn't need that dependency.

Onion Service V2 depreciation timeline:
https://blog.torproject.org/v2-deprecation-timeline/

@zolagonano
Copy link
Author

I don't know what data do you mean, if you mean sites data(like contect.json, index.html, etc) those are signed by ECDSA, not RSA.

@canewsin
Copy link
Collaborator

More than half of clients are using older version of ZeroNet, just an estimation. Tor even though stopped supporting v2, there are tor clients running v2(din't find the data, how many as of now), this is the reason for Zero Tor v2 Connections are available to communicate till today, lets take some stats from zerolink.ml for example, when i see the active connections for it, there are 100 active onion connections, out of those 20-30% are v3 connections remaining are all v2 conns.

@zolagonano
Copy link
Author

zolagonano commented Dec 26, 2021

More than half of clients are using older version of ZeroNet, just an estimation. Tor even though stopped supporting v2, there are tor clients running v2(din't find the data, how many as of now), this is the reason for Zero Tor v2 Connections are available to communicate till today, lets take some stats from zerolink.ml for example, when i see the active connections for it, there are 100 active onion connections, out of those 20-30% are v3 connections remaining are all v2 conns.

New tor clients cannot connect to Onion V2 anymore.

My tor logs when I want to connect into onion v2 domains:

Tried to connect to a v2 onion address, but this version of Tor no longer supports them. Please encourage the site operator to upgrade. For more information see https://blog.torproject.org/v2-deprecation-timeline.

But you're right, someone might use this fork with an older version of Tor, i'll bring RSA support back to the CryptTor.

@canewsin
Copy link
Collaborator

I will suggest you one thing, create a new branch with above changes, create a pr with that, in future we don't need to rework it and pr can be simply merged.

@canewsin
Copy link
Collaborator

while working on adding/remove features, always prefer to create new branch while making prs.

@canewsin canewsin closed this Dec 26, 2021
@zolagonano zolagonano mentioned this pull request Dec 26, 2021
marek22k pushed a commit to marek22k/ZeroNet that referenced this pull request Oct 30, 2023
return upnp punch using secure xml library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants