collect decom1 to message struct #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiba
reviewed
May 28, 2019
| @@ -43,6 +43,11 @@ pub struct KeyGenBroadcastMessage1 { | |||
| com: BigInt, | |||
| } | |||
|
|
|||
| pub struct KeyGenMessage2 { | |||
There was a problem hiding this comment.
Can we change it to KeyGenBroadcastMessage2 (note the Broadcast) for consistency?
oleiba
reviewed
May 28, 2019
| &y_vec[i].bytes_compressed_to_big_int(), | ||
| &blind_vec[i], | ||
| &decom1_vec[i].y_i.bytes_compressed_to_big_int(), | ||
| &decom1_vec[i].blind_factor, |
There was a problem hiding this comment.
I think it is better that this function (phase1_verify_com_phase2_distribute) will calculate and return y_sum.
Otherwise, this is necessarily code that would be written by the consuming application, and it's preferable to be calculated after gathering all the decommitments and verifying them, so I think it's a perfect place to do so.
oleiba
suggested changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.