Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow, update dependencies and add spawn module #1

Merged
merged 6 commits into from
Aug 21, 2022
Merged

Add workflow, update dependencies and add spawn module #1

merged 6 commits into from
Aug 21, 2022

Conversation

Elikill58
Copy link
Contributor

@Elikill58 Elikill58 commented Aug 21, 2022

Fixed:

  • Use latest API, fix error with new plugins

Added :

  • Github workflow
  • Spawn module with auto-generator

@Elikill58 Elikill58 changed the title Add workflow and update repo Add workflow, update dependencies and add spawn module Aug 21, 2022
@ZakShearman
Copy link
Owner

Thanks for the contribution.

I'm just gonna fix some styling issues with this. In the future I'll provide some styling guidance so people actually know what I'd prefer.

@ZakShearman
Copy link
Owner

Also not going to allow it to be switched to SNAPSHOT as it's known that sometimes SNAPSHOT just doesn't work with JitPack. Many people have experienced this when using Minestom and other projects.

@ZakShearman ZakShearman added the enhancement New feature or request label Aug 21, 2022
@ZakShearman
Copy link
Owner

lmk if you're happy with the changes that I've made just to make sure it hasn't removed any of your work and then I'm happy merging this.

I've left this project for a while and I'm probably going to look into improving some things here soon (maybe removing OPs, IMO should be separated into an extension and just use luckperms).

@Elikill58
Copy link
Contributor Author

Elikill58 commented Aug 21, 2022

Hi,
I'm happy that you look this quickly, and review it. So, thanks you for this.

Also, I suggest you to keep OP command until there isn't official release of Luckperms in Minestom

@ZakShearman ZakShearman merged commit e1165c3 into ZakShearman:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants