do not enable a service disabled by the user

[OniriCorpe]

The problem

if the admin disabled a service using yunohost service disable $app, an upgrade will enable and start it again

Solution

check in the systemd helpers if the service has been deactivated before activating or before starting it up

PR Status

done

How to test

...

[alexAubin]

Hmmm I think that part should be entirely removed ... the "start_on_boot" thing is precisely the systemd's enabled/disabled flag, cf https://github.com/YunoHost/yunohost/blob/bookworm/src/service.py#L433

so this code is basically "if the service is enabled, enable it"

Suggested change

	# do not enable a service disabled by the user
	if ! yunohost service status $service | grep -q "start_on_boot: disabled"; then
	systemctl enable $service --quiet
	fi

[OniriCorpe]

So how can we do to not re-enable an intentionally disabled service on update?

[alexAubin]

We just remove the original systemctl enable $service like you already did ? ;P

[OniriCorpe]

hummm yes x)
why is he here in the first place?

[alexAubin]

Because we did not really think about the use case of "the user wants the service to be disabled" i think

[OniriCorpe]

ah, but now if a packages uses ynh_add_systemd_config at installation, the service will not be enabled :/

[OniriCorpe]

the issue is during upgrade, not install