Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct French spelling in the manifest #22

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Correct French spelling in the manifest #22

merged 2 commits into from
Oct 10, 2020

Conversation

Linkid
Copy link
Contributor

@Linkid Linkid commented Aug 6, 2020

Problem

  • In the manifest, there are some spelling errors in the French description

Solution

  • French description corrected

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    Please replace '-NUM-' in this link by the PR number.
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

ericgaspar
ericgaspar requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@ericgaspar ericgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to repeat the name of the app in its description

manifest.json Outdated Show resolved Hide resolved
manifest.json Outdated Show resolved Hide resolved
@zamentur zamentur merged commit c1122ad into YunoHost-Apps:testing Oct 10, 2020
@Linkid Linkid deleted the description-spelling branch October 11, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericgaspar ericgaspar ericgaspar requested changes

@zamentur zamentur zamentur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Linkid @zamentur @ericgaspar