Fix track decoding API calls #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yucked
reviewed
Feb 4, 2024
src/Rest/DecodedLavaTrack.cs
Outdated
There was a problem hiding this comment.
Must we add another LavaTrack? My idea was to use TrackDeserializer to des the response into LavaTrack
| ArgumentNullException.ThrowIfNull(trackHash); | ||
| var responseMessage = await _httpClient.GetAsync($"/{_version}/decodetrack?encodedTrack={trackHash}"); | ||
| var responseMessage = await _httpClient.GetAsync($"/{_version}/decodetrack?encodedTrack={HttpUtility.UrlEncode(trackHash)}"); |
There was a problem hiding this comment.
Isn't trackHash already an encoded string?
There was a problem hiding this comment.
At least on both TrackEndEventArg and TrackStartEventArg, encodedTrack isn't URL-safe.
There was a problem hiding this comment.
Track obj
Line 100 in 7e93e94
…rter, added LavaTrackListConverter
…cifically, LavaTrackListConverter now reuses LavaTrackConverter
Yucked
reviewed
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecodedLavaTrackclass, which represents the JSON object returned byGET /v4/decodetrackand the elements in the array returned byPOST /v4/decodetracksLavaNode.DecodeTrackAsyncandLavaNode.DecodeTracksAsyncto use and returnDecodedLavaTrackLavaNode.DecodeTrackAsyncLavaNode.DecodeTracksAsynchttp-request as indicated by Lavalink docs