bug fixed in getBiasFactor

bug fixed in getBiasFactor

.Rproj.user/7DCFFB88/sdb/prop/INDEX

@@ -1 +1,7 @@
+~%2FGitHub%2Fhyfo%2FDESCRIPTION="9E7FEC5D"
+~%2FGitHub%2Fhyfo%2FNEWS="F6FD6B5D"
 ~%2FGitHub%2Fhyfo%2FR%2FbiasCorrect(generic).R="284FBADF"
+~%2FGitHub%2Fhyfo%2FR%2Fmulti-biasCorrect(generic).R="8D6FC6B0"
+~%2FGitHub%2Fhyfo%2FR%2Fncdf.R="3AC0369"
+~%2FGitHub%2Fhyfo%2FREADME.md="F3D2C6B8"
+~%2FGitHub%2Fhyfo%2Fvignettes%2Fhyfo.Rmd="7142D528"

.Rproj.user/shared/notebooks/paths

@@ -1,2 +1,3 @@
+C:/Users/User/Documents/GitHub/hyfo/vignettes/hyfo.Rmd="BE89A8F"
 C:/Users/user/Documents/GitHub/hyfo/R/extractPeriod(generic).R="35D21910"
 C:/Users/user/Documents/GitHub/hyfo/vignettes/hyfo.Rmd="E84A6BF8"

.gitignore

@@ -31,3 +31,4 @@ Network Trash Folder
 Temporary Items
 .apdisk
 inst/doc
+.Rproj.user

DESCRIPTION

@@ -1,8 +1,8 @@
 Package: hyfo
 Type: Package
 Title: Hydrology and Climate Forecasting
-Version: 1.3.9
-Date: 2017-2-20
+Version: 1.4.0
+Date: 2018-9-27
 Authors@R: person("Yuanchao", "Xu", email = "[email protected]",
  role = c("aut", "cre"))
 Description: Focuses on data processing and visualization in hydrology and
@@ -39,4 +39,4 @@ LazyData: true
 URL: https://yuanchao-xu.github.io/hyfo/
 BugReports: https://github.com/Yuanchao-Xu/hyfo/issues
 Repository: CRAN
-RoxygenNote: 6.0.1
+RoxygenNote: 6.1.0

NEWS

@@ -1,3 +1,11 @@
+hyfo 1.4.0
+==========
+Date: 2018-9-27
+
+- "memberIndex" length zero bug fixed in getBiasFactor
+
+
+
 hyfo 1.3.9
 ==========
 Date: 2017-2-20

R/biasCorrect(generic).R

@@ -286,6 +286,9 @@ biasCorrect.list <- function(frc, hindcast, obs, method, scaleType, preci, prThr
 
  # Now real bias correction is executed.
 
+ # for some forcasts, they have results from different models or scenarios, if so
+ # there will be a dimension called member
+
  memberIndex <- grepAndMatch('member', attributes(frcData)$dimensions)
 
  # For dataset that has a member part 

R/multi-biasCorrect(generic).R

@@ -437,11 +437,14 @@ getBiasFactor.list <- function(hindcast, obs, method, scaleType, preci, prThresh
 
 
  # Now real bias correction is executed.
+ # for some forcasts, they have results from different models or scenarios, if so
+ # there will be a dimension called member
+
 
  memberIndex <- grepAndMatch('member', attributes(hindcastData)$dimensions)
 
  # For dataset that has a member part 
- if (!is.na(memberIndex)) {
+ if (length(memberIndex) != 0) {
 
  hindcastData <- adjustDim(hindcastData, ref = c('lon', 'lat', 'time', 'member'))
 
@@ -573,7 +576,7 @@ applyBiasFactor.list <- function(frc, biasFactor, obs) {
  memberIndex <- grepAndMatch('member', attributes(frcData)$dimensions)
 
  # For dataset that has a member part 
- if (!is.na(memberIndex)) {
+ if (length(memberIndex) != 0) {
  # check if frcData and hindcastData has the same dimension and length.
  if (calcuDim(frcData, dim = 'member') != memberDim) {
  stop('frc data has different member number from hindcast.')