Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replication factor for scale-1 variant, and add an -ephemeral variant #266

Merged
merged 4 commits into from
Apr 27, 2019
Merged

Fix replication factor for scale-1 variant, and add an -ephemeral variant #266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce76440
Fixes a typo
solsson Apr 27, 2019
df4ff3b
Pretty good CI stack: kubectl apply -k variants/scale-1-ephemeral/
solsson Apr 27, 2019
f728b98
Fixes produce error for scale-1 kustomization
solsson Apr 27, 2019
870435a
There'll be lots of duplication among variants
solsson Apr 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
There'll be lots of duplication among variants 
because only files within kustomization.yaml's dir can be included
  • Loading branch information
@solsson
solsson committed Apr 27, 2019
commit 870435adf928bb9d40a227e8922b3525758acaf8
6 changes: 6 additions & 0 deletions variants/scale-1/kafka-scale1-overrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "default.replication.factor=1"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "min.insync.replicas=1"}
]
7 changes: 7 additions & 0 deletions variants/scale-1/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,10 @@ bases:
patchesStrategicMerge:
- kafka.yaml
- zookeeper.yaml
patchesJson6902:
- target:
group: apps
version: v1
kind: StatefulSet
name: kafka
path: kafka-scale1-overrides.json