Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS/QA: make all classes final #319

Merged
merged 1 commit into from
Nov 3, 2023
Merged

CS/QA: make all classes final #319

merged 1 commit into from
Nov 3, 2023

Commits on Nov 3, 2023

  1. CS/QA: make all classes final 

    The PHPCS native autoloader which YoastCS uses, doesn't always play nice with sniffs extending other sniffs, which can lead to fatal "Class already declared" errors.

With this in mind, all YoastCS classes will now be made `final`.

This will now also be enforced via a sniff available from PHPCSExtra.

Note: this is a breaking change!
    @jrfnl
    jrfnl committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    fd7d1e8 View commit details
    Browse the repository at this point in the history