Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Minor travis script tweak #27

Merged
merged 1 commit into from
Mar 21, 2017
Merged

🚀 Minor travis script tweak #27

merged 1 commit into from
Mar 21, 2017

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Mar 21, 2017

Run the setup in before_install instead of before_script to report failures in the setup as build errored instead of failed.

This is important as it determines there was an issue setting up your environment rather than the code you are testing against.

Copy link

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Run the setup in `before_install` instead of `before_script` to report failures in the setup as build `errored` instead of `failed`.

This is important as it determines there was an issue setting up your environment rather than the code you are testing against.
@atimmer atimmer merged commit 44d24a9 into master Mar 21, 2017
@atimmer atimmer deleted the JRF/minor-travis-tweaks branch March 21, 2017 15:01
@jrfnl jrfnl added this to the 0.4.x milestone Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants