Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running the Yoast SEO Premium upgrade routine #59

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

jdevalk
Copy link
Contributor

@jdevalk jdevalk commented Feb 4, 2020

This adds the option to set the Yoast SEO Premium database version, and thus the option to make the upgrade routine run. It also adds a notification when that upgrade routine has run.

Known caveats: this doesn't actually know whether the premium upgrade routine has fired, since there's no hook in premium to test for this, so it fires when the option is updated, which happens after the upgrade routines run, hence this message:

Screenshot 2020-02-04 at 13 36 17

Fixes #58

@moorscode
Copy link
Contributor

Code review 👍

@jdevalk jdevalk merged commit 7424e50 into develop Feb 4, 2020
@jdevalk jdevalk deleted the jdv/premium-upgrade-routine branch February 4, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade routine doesn't trigger Premium upgrade
2 participants