Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade routine doesn't trigger Premium upgrade #58

Closed
moorscode opened this issue Feb 4, 2020 · 0 comments · Fixed by #59
Closed

Upgrade routine doesn't trigger Premium upgrade #58

moorscode opened this issue Feb 4, 2020 · 0 comments · Fixed by #59

Comments

@moorscode
Copy link
Contributor

moorscode commented Feb 4, 2020 •
edited

Problem: Premium upgrade routines are not being run when setting the version number lower than the current version. The free-upgrade routines are run.
This is an unexpected flow and causes a lot of confusion.

We have only implemented the regular plugins:

Premium has an own version to check against for upgrade routines.
This is stored in the option: wpseo_premium_version
See: https://github.com/Yoast/wordpress-seo-premium/blob/trunk/premium/classes/upgrade-manager.php#L16

This version is not being set when saving a new version.
This should be implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow running the Yoast SEO Premium upgrade routine Yoast/yoast-test-helper
1 participant
@moorscode