Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change number of characters DB version #53 #54

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Change number of characters DB version #53 #54

merged 1 commit into from
Nov 14, 2019

Conversation

karlijnbok
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • N/A

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  1. Get the Yoast Test Helper plugin
  2. Go to Tools > Yoast Test and try to type 10.0-RC0 as DB Version for Yoast SEO
  3. See that this is not possible (not able to type more than 10.0-RC)
  4. Checkout this branch
  5. Go to Tools > Yoast Test and try to type 10.0-RC0 as DB Version for Yoast SEO
  6. See that this is now possible

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #53

@johannadevos
Copy link
Contributor

CR & Acceptance: 👍

@johannadevos johannadevos added this to the Next release milestone Nov 14, 2019
@johannadevos johannadevos merged commit 0db2406 into develop Nov 14, 2019
@johannadevos johannadevos deleted the 53-change-nr-characters-dbversion branch November 14, 2019 10:27
@IreneStr IreneStr added the 0.5 label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.5
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

Change number of characters DB version
3 participants
@karlijnbok @johannadevos @IreneStr