Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied best practices for regular expressions:
Checked all use of PHP preg_* functions for some best practices and consistency:
" as delimiter instead of "/" - "
" is a very unlikely character to ever be used in text and therefore a good delimiterpreg_quote()
if part of the pattern is unknown (user-input/database)pattern
may contain utf-8 characters. I did notice it already being there in some instances, even when not needed. I've not removed it if it was there and not needed, just to be on the safe side.N.B.: I couldn't find any unit tests to run on the changes - are there any available ? especially with regex, very useful to have ;-)
Open:
Not sure if this has ever been an issue, but it might be an idea to verify/evaluate those regexes again.
@todo
comments with my initials [JRF].